Skip to content

SAK-51265 Sitestats switch to using css icons for tools #13534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 23, 2025
Merged

SAK-51265 Sitestats switch to using css icons for tools #13534

merged 5 commits into from
Apr 23, 2025

Conversation

i-a-m-s-k
Copy link
Contributor

Replaced Silk icons with Sakai icons to maintain consistency.

@jesusmmp
Copy link
Contributor

jesusmmp commented Apr 2, 2025

Do we have some photos?

@i-a-m-s-k
Copy link
Contributor Author

I added it to the Jira: https://sakaiproject.atlassian.net/browse/SAK-51265.

kunaljaykam
kunaljaykam reviewed Apr 3, 2025
View reviewed changes
Copy link
Member

@kunaljaykam kunaljaykam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon mappings are already being done by sakai-icons

stetsche
stetsche requested changes Apr 3, 2025
View reviewed changes
@stetsche
Copy link
Contributor

stetsche commented Apr 3, 2025

Nice to see more of the silk icons getting removed, thanks @i-a-m-s-k !

@i-a-m-s-k
Copy link
Contributor Author

@stetsche @kunaljaykam thank you for the input, I have updated the code. Kindly review.

stetsche
stetsche reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@stetsche stetsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good now, thanks! Just one doubt.

@ern ern changed the title SAK-51265 Sitestats Add Sakai Icons SAK-51265 Sitestats switch to using css icons for tools Apr 10, 2025
ottenhoff
ottenhoff approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@ottenhoff ottenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be nice to get rid of nav-plus.gif!

sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/components/EventRegistryTree.java:124: ExternalImage navExpand = new ExternalImage("navExpand", StatsManager.SITESTATS_WEBAPP + "/images/nav-plus.gif");
sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/components/EventRegistryTree.java:152: listItem.add(new ExternalImage("navExpand", StatsManager.SITESTATS_WEBAPP + "/images/nav-plus.gif").setVisible(false));
sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/components/EventRegistryTree.java:169: listItem.add(new ExternalImage("navExpand", StatsManager.SITESTATS_WEBAPP + "/images/nav-plus.gif").setVisible(false));

@csev csev merged commit 1656d39 into sakaiproject:master Apr 23, 2025
5 checks passed
ern pushed a commit that referenced this pull request Apr 24, 2025
@i-a-m-s-k @ottenhoff @ern
SAK-51265 Sitestats switch to using css icons for tools (#13534)
02ec8da 
Co-authored-by: Sam Ottenhoff <[email protected]>
(cherry picked from commit 1656d39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ern ern ern left review comments

@ottenhoff ottenhoff ottenhoff approved these changes

@stetsche stetsche stetsche requested changes

@kunaljaykam kunaljaykam Awaiting requested review from kunaljaykam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@i-a-m-s-k @jesusmmp @stetsche @ern @ottenhoff @kunaljaykam @csev